Fix unreachable_pub lint
#675
Merged
+72
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarfonthey
force-pushed
the
unreachable-pub
branch
from
2e4c45f to
c5e2c95
Compare
Member
|
I would prefer if we did actually enable |
Contributor
Author
|
That won't cause issues with |
Member
|
As per the discussion in #650 we should be able to raise MSRV to 1.84 at least. |
Contributor
Author
|
I'll do that in a separate PR, then, and add this afterward, so that the update for MSRV can come with various clippy fixes as well. (Edition is 1.85, so, not that though.) |
Contributor
Author
|
Wrong order, but I can update my MSRV PR 😅 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #669, a method marked
pubhad to be changed topub(crate)in order to satisfy MSRV. Essentially, MSRV is not smart enough to determine that a method markedpubwhich is actually inaccessible outside the crate is not leaking private types, and so, we need to fix this.I decided to automatically fix all instances of the
unreachable_publint since, although MSRV does not have this lint, it could benefit from this change in the future, and it's better to make the changes now than have to sprinkle them occasionally later. I also see no need to permanently try and catch the lint in CI, since this is only a theoretically useful change. (Also, it has a few false positives, like changingBuckettopub(crate)not being allowed due to being present in public trait implementations, despite the type itself not being public.)